Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateRangePicker] Add accessible name to calendar grid #13538

Merged
merged 5 commits into from
Jun 19, 2024
Merged

[DateRangePicker] Add accessible name to calendar grid #13538

merged 5 commits into from
Jun 19, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jun 19, 2024

Fixes #13534

  • Add id and aria-labelledby relationship to DateRangeCalendar same as we have for DateCalendar.
  • Update tests to benefit from this relationship instead of accessing parent elements and relying on consistent DOM.

@LukasTy LukasTy added bug 🐛 Something doesn't work accessibility a11y component: pickers This is the name of the generic UI component, not the React module! component: DateRangePicker The React component. labels Jun 19, 2024
@LukasTy LukasTy self-assigned this Jun 19, 2024
@mui-bot
Copy link

mui-bot commented Jun 19, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13538--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 9d24724

@LukasTy LukasTy requested a review from a team June 19, 2024 08:09
@LukasTy
Code review: Flavien
db9bc95 
Better support for custom calendar header components
@LukasTy
scripts
9d24724
flaviendelangle
flaviendelangle approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ❤️
Thanks for taking care of it

@LukasTy LukasTy enabled auto-merge (squash) June 19, 2024 09:10
@LukasTy LukasTy merged commit 05dd41f into mui:master Jun 19, 2024
15 checks passed
@LukasTy LukasTy deleted the fix-date-range-calendar-grid-label branch June 19, 2024 09:15
This was referenced Jul 13, 2024
Open
Open
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 20, 2024
Open
Open
@Carment14tham Carment14tham mentioned this pull request Jul 20, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@LukasTy @DungTiger
[DateRangePicker] Add accessible name to calendar grid (mui#13538)
772d95d
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@LukasTy @thomasmoon
[DateRangePicker] Add accessible name to calendar grid (mui#13538)
e13cfaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees

@LukasTy LukasTy

Labels
accessibility a11y bug 🐛 Something doesn't work component: DateRangePicker The React component. component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] DateRangeCalendar grid is missing it's accessible name
3 participants
@LukasTy @mui-bot @flaviendelangle